refactor: improve python integration by using magick method and properties #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
requested review from
echambla,
etiennearnal,
jomadec and
Revathyvenugopal162
as code owners
SMoraisAnsys
force-pushed
the
refactor/use-magick-methods
branch
from
dd414d1 to
8a540d9
Compare
|
@SMoraisAnsys in regards to the properties: How to combine the properties with the usage of fluent API methodology currently implemented. in regards for the getitem i didn't know about that magic method. so great idea |
|
Closing as superseded by the POC #453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently a WIP. The changes are:
__getitem__instead of theget_itemmethod that was implemented. The great thing with that change is that any use can now callspeos_client[my_key]instead ofspeos_client.get_item(key=my_key). It's a good practice to implement magick methods when they make sense.propertyto propose something simple to our users while hidding the complexity. This way, a user will think he is playing with an attribute when, behind the scene, there is something complexe going on. It is also a good practice in Python.Note
I used
propertyfor theFaceclass, if the change is accepted, we can think about applying it to allscriptfiles